fix: navigation when clicking on the grid on a custom week/month #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I converted the FullCalendar options to a computed prop again. It still works in private and public widgets. I assume this was just an oversight. This also means that we can get rid of some reactivity hacks again as the computed prop is now properly reactive again. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5999 +/- ##
============================================
+ Coverage 23.51% 23.54% +0.02%
Complexity 455 455
============================================
Files 246 246
Lines 11718 11707 -11
Branches 2154 2142 -12
============================================
Hits 2756 2756
+ Misses 8647 8637 -10
+ Partials 315 314 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit a40a200. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
hamza221
approved these changes
May 13, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
backportbot
bot
added
the
backport-request
This comment was marked as resolved.
This comment was marked as resolved.
|
Hmm, private widgets were not backported to stable4.7 so we should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5891
Reverts #5995
I converted the FullCalendar options to a computed prop again. It still works in private and public widgets. I assume this was just an oversight. This also means that we can get rid of some reactivity hacks as the computed prop is now properly reactive again.
How to reproduce
Regression testing
Things that I tested successfully: